netdev - Re: [PATCH net-next 0/2] net: phy: don't stop state machine in case of MDIO error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1c51c1f-1259-53b7-ad59-0556a00d3976@gmail.com>
Date:   Sun, 16 Dec 2018 09:29:16 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        Fugang Duan <fugang.duan@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: don't stop state machine in case
 of MDIO error

On 15.12.2018 17:17, Heiner Kallweit wrote:
> If we detect a MDIO error, it seems to be a little bit too aggressive
> to stop the state machine and bring down the PHY completely.
> E.g. when polling and we miss one update, then this has no relevant
> impact.
> 
> Heiner Kallweit (2):
>   net: phy: don't stop state machine in case of MDIO error
>   net: fec: remove workaround to restart state machine on MDIO error
> 
>  drivers/net/ethernet/freescale/fec.h      |  1 -
>  drivers/net/ethernet/freescale/fec_main.c | 12 -------
>  drivers/net/phy/phy.c                     | 42 +++++------------------
>  include/linux/phy.h                       |  2 +-
>  4 files changed, 10 insertions(+), 47 deletions(-)
> 
David, could you please wait with applying this? I should have marked
it RFC (did so in patchwork meanwhile), need to discuss it with
Andrew and Florian.

Heiner