netdev - Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1544968346.4766.3.camel@debian.org>
Date:   Sun, 16 Dec 2018 13:52:26 +0000
From:   Luca Boccassi <bluca@...ian.org>
To:     Petr Vorel <pvorel@...e.cz>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2 3/4] tests: delete dummy interface after
 default route test

On Sat, 2018-12-15 at 17:32 +0100, Petr Vorel wrote:
> Hi Luca,
> 
> > Signed-off-by: Luca Boccassi <bluca@...ian.org>
> 
> Reviewed-by: Petr Vorel <pvorel@...e.cz>
> > ---
> >  testsuite/tests/ip/route/add_default_route.t | 2 ++
> >  1 file changed, 2 insertions(+)
> > diff --git a/testsuite/tests/ip/route/add_default_route.t
> > b/testsuite/tests/ip/route/add_default_route.t
> > index 569ba1f8..c536e35f 100755
> > --- a/testsuite/tests/ip/route/add_default_route.t
> > +++ b/testsuite/tests/ip/route/add_default_route.t
> > @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst
> > cafe:babe::/64" -6 route add cafe:babe::/
> >  ts_ip "$0" "Show IPv6 default route" -6 route show default
> >  test_on "default via dead:beef::2 dev $DEV"
> >  test_lines_count 1
> > +
> > +ts_ip "$0" "Del $NEW_DEV dummy interface"  link del dev $DEV
> 
> Shouldn't this be using $DEV instead of $NEW_DEV?
> ts_ip "$0" "Delete $DEV interface" link del dev $DEV
> 
> Copy paste from new_link.t?

Ops! Yes indeed, copy-pasta, fixed in v2, thanks.

-- 
Kind regards,
Luca Boccassi
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)