netdev - Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f1fa411-8fe5-cfdb-f846-87dca51c69c8@gmail.com>
Date:   Mon, 17 Dec 2018 08:07:44 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Christoph Paasch <cpaasch@...le.com>
Cc:     netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts



On 12/17/2018 07:49 AM, Christoph Paasch wrote:

> It gets called from tcp_fastopen_destroy_cipher() though (to destroy the
> socket's TFO-keys when the socket gets closed). There it has to destroy the
> whole list.
> 
> Same when going through exit_batch for the namespace.
> 
> 
> We could of course split it in tcp_fastopen_ctx_free_one() and
> tcp_fastopen_ctx_free_all(). But maybe that's overkill as it's a rare thing
> to do?


No, this is fine, please see my second review of this first patch.

Thanks.