netdev - Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217212805.GF19725@lunn.ch>
Date:   Mon, 17 Dec 2018 22:28:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...il.com>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: set ethtool regs version

On Mon, Dec 17, 2018 at 04:05:21PM -0500, Vivien Didelot wrote:
> From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> 
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
> 
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.

Hi Vivien.

I like this, but it is still not guaranteed to be unique between DSA
drivers.

I suppose once we do get a clash, we can add some extra heuristics.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew