netdev - Re: [PATCH 1/3] 9p/net: implement asynchronous rpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bcb0d99-fc35-3390-e751-5c4ad623e418@gmail.com>
Date:   Mon, 17 Dec 2018 23:14:53 +0100
From:   Tomas Bortoli <tomasbortoli@...il.com>
To:     Dominique Martinet <asmadeus@...ewreck.org>
Cc:     v9fs-developer@...ts.sourceforge.net,
        Dominique Martinet <dominique.martinet@....fr>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Eric Van Hensbergen <ericvh@...il.com>,
        Latchesar Ionkov <lucho@...kov.net>,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH 1/3] 9p/net: implement asynchronous rpc

On 12/17/18 12:01 PM, Dominique Martinet wrote:
> Tomas Bortoli wrote on Mon, Dec 17, 2018:
>> sorry for the delay, I've been quite busy these days.
> 
> No problem.
> 
>> The patches looks good to me and should indeed speed up the code a bit.
>> I quickly tested them against Syzkaller tuned for the 9p subsystem and
>> everything seems fine.
> 
> Thanks, can I add your Reviewed-by on all three?
> 

Sure, FWIW.

>> And by the way, which refcount races?
> 
> There's a problem with trans_fd read_work and cancelled callback; I'm
> not so sure about refcount but we can definitely get double list_del
> as we're not checking the status. I think when we incorrectly remove
> from the list we also mismanage the refcount, but honestly need to
> test..
> 

Yeah, definitely it needs  to check the status. Btw, if a double
list_del happens the kernel should crash.