netdev - Re: [PATCH net v2 2/4] vxlan: Fix error path in __vxlan_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wihefafafi3.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Mon, 17 Dec 2018 23:41:05 +0000
From:   Petr Machata <petrm@...lanox.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
CC:     netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net v2 2/4] vxlan: Fix error path in __vxlan_dev_create()

Roopa Prabhu <roopa@...ulusnetworks.com> writes:

>> @@ -3297,9 +3298,15 @@ static int __vxlan_dev_create(struct net *net, struct net_device *dev,
>>
>>         list_add(&vxlan->next, &vn->vxlan_list);
>>         return 0;
>> +
>>  errout:
>> +       /* unregister_netdevice() destroys the default FDB entry with deletion
>> +        * notification. But the addition notification was not sent yet, so
>> +        * destroy the entry by hand here.
>> +        */
>>         if (f)
>>                 vxlan_fdb_destroy(vxlan, f, false);
>> +       unregister_netdevice(dev);
>
> if (unregister_netdev_onerr)
>          unregister_netdevice

All right, I'll send v3 tomorrow.