netdev - RE: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OSAPR01MB229035772BF81EDC3F58C2F6D8BC0@OSAPR01MB2290.jpnprd01.prod.outlook.com>
Date:   Mon, 17 Dec 2018 10:46:41 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
CC:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

Hello Andrew, Florian,

> From: Andrew Lunn, Sent: Tuesday, December 4, 2018 7:44 PM
> 
> > > Series applied, thank you.
> >
> > Meh! I guess we should be faster at reviewing stuff :/
> 
> And there have been things going on behind the scenes to try to get a
> real fix. Sorry, i should of mentioned that.

Sorry for the delayed response. How to try to get a real fix?
I have two ideas:

Idea 1: Assert/deassert the reset in phy_{suspend,resume}()
 - call phy_device_reset(phydev, 0); if !phydev->attached_dev in phy_suspend()
 - call phy_device_reset(phydev, 1); if !phydev->attached_dev in phy_resume()

Idea 2: Toggle the reset in phy_resume().
 - call phy_device_reset(phydev, 0); udelay(1); phy_device_reset(phydev, 1);
   if !phydev->attached_dev in phy_resume ()

I think the idea 1 is better. But, what do you think?

Best regards,
Yoshihiro Shimoda