netdev - Re: [PATCH] [v2] test_rhashtable: remove semaphore usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217142503.tylhv4l5rbtthc2g@gondor.apana.org.au>
Date:   Mon, 17 Dec 2018 22:25:04 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     netdev@...r.kernel.org, "Acked-by : Phil Sutter" <phil@....cc>,
        Thomas Graf <tgraf@...g.ch>,
        "David S. Miller" <davem@...emloft.net>,
        NeilBrown <neilb@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] test_rhashtable: remove semaphore usage

On Sun, Dec 16, 2018 at 08:48:21PM +0100, Arnd Bergmann wrote:
> This is one of only two files that initialize a semaphore to a negative
> value. We don't really need the two semaphores here at all, but can do
> the same thing in more conventional and more effient way, by using a
> single waitqueue and an atomic thread counter.
> 
> This gets us a little bit closer to eliminating classic semaphores from
> the kernel. It also fixes a corner case where we fail to continue after
> one of the threads fails to start up.
> 
> An alternative would be to use a split kthread_create()+wake_up_process()
> and completely eliminate the separate synchronization.
> 
> Acked-by: Phil Sutter <phil@....cc>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt