netdev - Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181218164528.GA22449@lunn.ch>
Date:   Tue, 18 Dec 2018 17:45:28 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Bryan.Whitehead@...rochip.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

On Tue, Dec 18, 2018 at 04:41:20PM +0000, Bryan.Whitehead@...rochip.com wrote:
> > > -	/* set to internal PHY id */
> > > -	adapter->mdiobus->phy_mask = ~(u32)BIT(1);
> > > +	if ((adapter->csr.id_rev & ID_REV_ID_MASK_) ==
> > ID_REV_ID_LAN7430_)
> > > +		/* LAN7430 uses internal phy at address 1 */
> > > +		adapter->mdiobus->phy_mask = ~(u32)BIT(1);
> > 
> > Hi Bryan
> > 
> > Does LAN7430 have an external MDIO bus as well as the internal one? Is
> > there a possibility for a PHY at address 0? If not, you can probably just not
> > have a mask at all.
> > 
> >      Andrew
> 
> Hi Andrew,
> 
> The LAN7430 does not have an external MDIO bus.
> And there is no possibility for a PHY at address 0.
> The reason I kept the mask for LAN7430 case is to reduce effort in finding the phy.
> Since Linux will scan all addresses in that case unnecessarily.
> 
> But I have tested your suggestion and it does work without a mask. 
> So I'm fine either way.

Hi Bryan

Lets keep the patch as it is. As you said, it speeds things up, and
since there is no external MDIO bus, nobody can add a second PHY, or a
switch chip, etc.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew