netdev - Re: DSA: external phy address and port number of switch conflicts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5C1942B6.8090506@gmail.com>
Date:   Tue, 18 Dec 2018 13:55:50 -0500
From:   John Rama <john.rama01@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: DSA: external phy address and port number of switch conflicts

Hi Florian, 

On 2018/12/17 18:03, Florian Fainelli wrote:
> On 12/17/18 2:55 PM, John Rama wrote:
>> Hi, Andrew, Florian and Viven
>>
>> thank you your feedback !!
>>
>>>> I would recommend checking a newer kernel anyway which would have
>>>> support for the mv88e6xxx internal MDIO bus as it might allow you to
>>>> solve that specific problem. A kernel that contains
>>>> a3c53be55c955b7150cda17874c3fcb4eeb97a89 ("net: dsa: mv88e6xxx: Support
>>>> multiple MDIO busses") might work better and actually help here, though
>>>> I don't know enough about that specific switch model, Andrew or Vivien
>>>> would.
>>>>
>>>>>
>>
>> I tried with kernel 4.9.0, and confirmed that same problem happens.
>> (I wanted to try more latest one, but newer version is using phylink,
>>  which I need couple of time to understand how it works)
>> I think this is not the driver side issue, maybe dsa side (but not sure for newer kernel)
>> or I misunderstanding some concept.
>>  
>>> Since you have the switch in single address mode, i don't see why this
>>> should not work.
>>
>> Why conflicts happens is because of the code at slave.c (@kernel 4.9.0)
>>
>> /* pseudo code */
>> dsa_slave_phy_setup() {                                     
>>   phy_dn = of_parse_phandle(port_dn, "phy-handle", 0);      
>>     if (phy_dn) {                                             
>> 	phy_id = of_mdio_parse_addr(&slave_dev->dev, phy_dn); 
>> 	dsa_slave_phy_connect(p, slave_dev, phy_id); <= register with phy_id
>>     }
>>     if (!p->phy) {
>> 	dsa_slave_phy_connect(p, slave_dev, p->port); <= register with port number
>>     }
>> }
> 
> That was later fixed with this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=399ba77a94e1ee01f747b168c429a121164ac962
> 
> can you try to backport that change and see if that helps?
> 

Yes, that's the one !!
I confirmed that the problem is solved by backporting this patch to both kernel 4.9.0 and 4.1.15.

Thanks a lot.

John