netdev - Re: [PATCH bpf-next 0/3] add size field to sk_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 00:32:49 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, ast@...nel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 0/3] add size field to sk_msg_md

On 12/17/2018 12:47 AM, John Fastabend wrote:
> This adds a size field to the sk_msg_md data structure used by SK_MSG
> programs. Without this in the zerocopy case and in the copy case
> where multiple iovs are in use its difficult to know how much data
> can be pulled in. The normal method of reading data and data_end
> only give the current contiguous buffer. BPF programs can attempt to
> pull in extra data but have to guess if it exists. This can result
> in multiple "guesses" its much better if we know upfront the size
> of the sk_msg.
> 
> John Fastabend (3):
>   bpf: sockmap, metadata support for reporting length of message
>   bpf: add tools lib/include support sk_msg_md size field
>   bpf: sk_msg, add tests for size field
> 
>  include/linux/skmsg.h                       |  3 +++
>  include/uapi/linux/bpf.h                    |  1 +
>  net/core/filter.c                           |  6 ++++++
>  tools/include/uapi/linux/bpf.h              |  1 +
>  tools/testing/selftests/bpf/test_verifier.c | 16 +++++++++++++---
>  5 files changed, 24 insertions(+), 3 deletions(-)
> 

Applied, thanks!