netdev - Re: [PATCH bpf-next] bpf: log struct/union attribute for forward type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 00:49:46 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, ast@...com, netdev@...r.kernel.org
Cc:     kernel-team@...com
Subject: Re: [PATCH bpf-next] bpf: log struct/union attribute for forward type

On 12/18/2018 10:43 PM, Yonghong Song wrote:
> Current btf internal verbose logger logs fwd type as
>   [2] FWD A type_id=0
> where A is the type name.
> 
> Commit 9d5f9f701b18 ("bpf: btf: fix struct/union/fwd types
> with kind_flag") introduced kind_flag which can be used
> to distinguish whether a forward type is a struct or
> union.
> 
> Also, "type_id=0" does not carry any meaningful
> information for fwd type as btf_type.type = 0 is simply
> enforced during btf verification and is not used
> anywhere else.
> 
> This commit changed the log to
>   [2] FWD A struct
> if kind_flag = 0, or
>   [2] FWD A union
> if kind_flag = 1.
> 
> Acked-by: Martin KaFai Lau <kafai@...com>
> Signed-off-by: Yonghong Song <yhs@...com>

Applied, thanks!