netdev - Re: [PATCH net-next] nfp: flower: fix cb_ident duplicate in indirect block register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Dec 2018 23:35:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     ecree@...arflare.com, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, john.hurley@...ronome.com
Subject: Re: [PATCH net-next] nfp: flower: fix cb_ident duplicate in
 indirect block register

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Mon, 17 Dec 2018 19:18:39 -0800

> From: John Hurley <john.hurley@...ronome.com>
> 
> Previously the identifier used for indirect block callback registry and
> for block rule cb registry (when done via indirect blocks) was the pointer
> to the netdev we were interested in receiving updates on. This worked fine
> if a single app existed that registered one callback per netdev of
> interest. However, if multiple cards are in place and, in turn, multiple
> apps, then each app may register the same callback with the same
> identifier to both the netdev's indirect block cb list and to a block's cb
> list. This can lead to EEXIST errors and/or incorrect cb deletions.
> 
> Prevent this conflict by using the app pointer as the identifier for
> netdev indirect block cb registry, allowing each app to register a unique
> callback per netdev. For block cb registry, the same app may register
> multiple cbs to the same block if using TC shared blocks. Instead of the
> app, use the pointer to the allocated cb_priv data as the identifier here.
> This means that there can be a unique block callback for each app/netdev
> combo.
> 
> Fixes: 3166dd07a9cb ("nfp: flower: offload tunnel decap rules via indirect TC blocks")
> Reported-by: Edward Cree <ecree@...arflare.com>
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied.