netdev - Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Dec 2018 10:39:52 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver
 features

On Tue, Dec 18, 2018 at 07:34:50AM +0100, Heiner Kallweit wrote:
> Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected,
> therefore it's not needed to define this manually in the driver.
> genphy_config_init() will remove 1Gbps from phydev->supported if
> not supported. Having said that PHY drivers for 100Mbps not
> calling genphy_config_init() still have to set the features field.
> As most PHY's are 1Gbps-capable let's use this as default.

Hi Heiner

I'm not sure i like this. Today most PHYs are 1G. But multi-gige PHYs
are starting to appear. In 5 years time, i expect most new PHYs will
be 2.5G and 5G capable, maybe 10G. We then end up with the odd
situation that 10M, 100M and 2.5G, 5G and 10G all need features, but 1G
not.

I would prefer to keep it consistent and always have a features.

  Andrew