netdev - Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wih4lbb9j4b.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Tue, 18 Dec 2018 11:20:35 +0000
From:   Petr Machata <petrm@...lanox.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default
 remotes

Roopa Prabhu <roopa@...ulusnetworks.com> writes:

> On Mon, Dec 17, 2018 at 3:44 PM Petr Machata <petrm@...lanox.com> wrote:
>>
>> Roopa Prabhu <roopa@...ulusnetworks.com> writes:
>> >> Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify ordering during netdev create")
>> >> Signed-off-by: Petr Machata <petrm@...lanox.com>
>> >> ---
>> >
>> > Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>
>> >
>> > This fix looks fine. But it almost seems like the changelink Fixes tag
>> > is more appropriate here unless you are
>> > sure that it worked correctly after the changelink.
>>
>> I don't follow. What do you mean?
>
> I meant the notify patch in the Fixes tag had no intentions to change
> this. Also the vxlan changelink support
> did not consider this as a test case. So i was wondering if this
> problem existed before the commit in the Fixes tag.

That patch changed vxlan_fdb_update() to vxlan_fdb_create() in two
instances: on changelink, and on create. In changelink, always calling
create may lead to a split of the default FDB entry. The fix is
basically a revert of that part of the patch.

> regardless, ack on the fix. thanks.