netdev - Re: [PATCH net-next] xfrm: policy: remove set but not used variable 'priority'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181219091313.ab7xl2y7wldffpwc@breakpoint.cc>
Date:   Wed, 19 Dec 2018 10:13:13 +0100
From:   Florian Westphal <fw@...len.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] xfrm: policy: remove set but not used variable
 'priority'

YueHaibing <yuehaibing@...wei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> net/xfrm/xfrm_policy.c: In function 'xfrm_policy_lookup_bytype':
> net/xfrm/xfrm_policy.c:2079:6: warning:
>  variable 'priority' set but not used [-Wunused-but-set-variable]
> 
> It not used since commit 6be3b0db6db8 ("xfrm: policy: add inexact policy
> search tree infrastructure")

Acked-by: Florian Westphal <fw@...len.de>

Removing this appears correct, the exact policy gets passed to
xfrm_policy_eval_candidates where the priority is checked.