netdev - Request for stable backport: stmmac: Use correct values in TQS/RQS fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181219095516.GA7747@centauri.lan>
Date:   Wed, 19 Dec 2018 10:55:16 +0100
From:   Niklas Cassel <niklas.cassel@...aro.org>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, vinod.koul@...aro.org
Subject: Request for stable backport: stmmac: Use correct values in TQS/RQS
 fields

Hello David,

I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac
with multiple tx queues.

Backporting the following commit:

commit 52a76235d0c4dd259cd0df503afed4757c04ba1d                                                  
Author: Jose Abreu <Jose.Abreu@...opsys.com>
Date:   Fri Oct 13 10:58:36 2017 +0100                                                           
                                                                                                 
    net: stmmac: Use correct values in TQS/RQS fields                                            

    Currently we are using all the available fifo size in RQS and                                
    TQS fields. This will not work correctly in multi-queues IP's                                
    because total fifo size must be splitted to the enabled queues.                              
                                                                                                 
    Correct this by computing the available fifo size per queue and                              
    setting the right value in TQS and RQS fields.                                               
                                                                                                 
    Signed-off-by: Jose Abreu <joabreu@...opsys.com>                                             
    Cc: David S. Miller <davem@...emloft.net>                                                    
    Cc: Joao Pinto <jpinto@...opsys.com>
    Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>                                              
    Cc: Alexandre Torgue <alexandre.torgue@...com>                                               
    Signed-off-by: David S. Miller <davem@...emloft.net>


resolves the issue.

The fix was first included in v4.15
$ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
v4.15
v4.15-rc1
v4.15-rc2

Could you please queue it up for 4.14 stable?


Kind regards,
Niklas