netdev - Re: [PATCH net] net: mvneta: fix operation for 64K PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181219181532.64558a46@xhacker.debian>
Date:   Wed, 19 Dec 2018 10:21:44 +0000
From:   Jisheng Zhang <Jisheng.Zhang@...aptics.com>
To:     Marcin Wojtas <mw@...ihalf.com>
CC:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        netdev <netdev@...r.kernel.org>,
        Grégory Clement <gregory.clement@...tlin.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        "nadavh@...vell.com" <nadavh@...vell.com>,
        Grzegorz Jaszczyk <jaz@...ihalf.com>,
        Stefan Chulski <stefanc@...vell.com>,
        David Miller <davem@...emloft.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE

On Wed, 19 Dec 2018 10:24:37 +0100 Marcin Wojtas wrote:

> Hi Jisheng,
> 
> śr., 19 gru 2018 o 04:11 Jisheng Zhang <Jisheng.Zhang@...aptics.com> napisał(a):
> >
> >
> > On Mon, 17 Dec 2018 08:37:35 +0100 Thomas Petazzoni wrote:
> >  
> > > Hello Marcin,
> > >
> > > On Mon, 17 Dec 2018 00:25:58 +0100, Marcin Wojtas wrote:
> > >  
> > > > Thanks. Indeed, the patch is valid as a fix for current version of SW
> > > > BM. However, because this concept is broken, I will rework it and
> > > > submit patch/patches some time early 2019.  
> > >
> > > I know some people are working on XDP support in mvneta, and this work
> > > also needs to change parts of the memory allocation strategy in this
> > > driver. I'd suggest to get in touch with those folks. Antoine can give
> > > you the contact details, I don't have them off-hand. Or perhaps they
> > > will see this e-mail :-)  
> >
> > Great. So the problem of current memory allocation is seen, glad to
> > know reworking is going on.
> >
> > Besides the memory waste, there's another issue with commit 7e47fd84b56b
> > it always allocates page, so the rx is mapped with dmap_map_page(), but
> > the unmap routine isn't updated, there's mismatch here.
> >  
> 
> Indeed, despite the upcoming rework, which will be more complex, how
> about I submit a quick patch for this?

That's better. Thank you