netdev - Re: linux-next: build warnings after merge of the wireless-drivers-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sgytvgdo.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 19 Dec 2018 14:40:51 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Grumbach\, Emmanuel" <emmanuel.grumbach@...el.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Wireless <linux-wireless@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Sharon\, Sara" <sara.sharon@...el.com>,
        "Coelho\, Luciano" <luciano.coelho@...el.com>,
        Kees Cook <keescook@...gle.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "David Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the wireless-drivers-next tree

"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com> writes:

>> 
>> Stephen Rothwell <sfr@...b.auug.org.au> writes:
>> 
>> > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell
>> <sfr@...b.auug.org.au> wrote:
>> >>
>> >> After merging the wireless-drivers-next tree, today's linux-next
>> >> build
>> >> (x86_64 allmodconfig) produced these warnings:
>> >>
>> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function
>> 'iwl_parse_tlv_firmware':
>> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> >>     if (iwlwifi_mod_params.enable_ini)
>> >>        ^
>> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
>> >>    default:
>> >>    ^~~~~~~
>> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function
>> 'iwl_parse_fw_dbg_tlv':
>> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> >>     iwl_fw_dbg_copy_tlv(trans, tlv, true);
>> >>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
>> >>    default:
>> >>    ^~~~~~~
>> >>
>> >> Introduced by commit
>> >>
>> >>   f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
>> >>
>> >> These are noted because I use -Wimplict-fallthrough
>> >>
>> >> The warnings can be suppressed by adding a comment like
>> >> 	/* fall through */
>> >> at the appropriate place to indicate that the fallthough is intended.
>> >
>> > I am still seeing these warnings (but in the net-next tree now) and I
>> > do not see a fix patch in the wireless-drivers-next tree.
>> 
>> Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
>> patches for iwlwifi (even in the one pending pull request he sent), not sure
>> what happened. I know that Luca is already on holidays but adding
>> Emmanuel, maybe he can help here?
>> 
>
> Just sent a patch.

I see it thanks:

https://patchwork.kernel.org/patch/10736967/

I'll try to get it to tomorrow's linux-next build.

-- 
Kalle Valo