netdev - Re: [PATCH net-next 1/2] neighbour: register rtnl doit handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <691a9e3d-620b-13a5-9082-511b47188946@cumulusnetworks.com>
Date:   Wed, 19 Dec 2018 09:39:12 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] neighbour: register rtnl doit handler

On 12/19/18 9:27 AM, Roopa Prabhu wrote:
> +	for (i = 0; i <= NDA_MAX; ++i) {
> +		if (!tb[i])
> +			continue;
> +
> +		switch (i) {
> +		case NDA_DST:
> +			if (nla_len(tb[NDA_DST]) < (int)(*tbl)->key_len) {

that should != instead of <; the address should be exactly the number of
bytes for the address family.

...

> +	if (ndm_flags & NTF_PROXY) {
> +		struct pneigh_entry *pn;
> +
> +		pn = pneigh_lookup(tbl, net, dst, dev, 0);
> +		if (!pn) {
> +			NL_SET_ERR_MSG(extack, "Proxy neighbour entry not found");
> +			return -ENOENT;
> +		}
> +		return pneigh_get_reply(net, pn, NETLINK_CB(in_skb).portid,
> +					nlh->nlmsg_seq, tbl);
> +	}
> +
> +	if (!dev) {
> +		NL_SET_ERR_MSG(extack, "No Device specified");

"No device ..."