netdev - Re: [PATCH net-next 1/2] neighbour: register rtnl doit handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUhz1TUfTL4-hop4pvC2y1B2fx4v1oWSX110=D2psGx0-g@mail.gmail.com>
Date:   Wed, 19 Dec 2018 11:24:31 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] neighbour: register rtnl doit handler

On Wed, Dec 19, 2018 at 8:39 AM David Ahern <dsa@...ulusnetworks.com> wrote:
>
> On 12/19/18 9:27 AM, Roopa Prabhu wrote:
> > +     for (i = 0; i <= NDA_MAX; ++i) {
> > +             if (!tb[i])
> > +                     continue;
> > +
> > +             switch (i) {
> > +             case NDA_DST:
> > +                     if (nla_len(tb[NDA_DST]) < (int)(*tbl)->key_len) {
>
> that should != instead of <; the address should be exactly the number of
> bytes for the address family.
>

picked this up from neigh_add. But agree on != check.


> ...
>
> > +     if (ndm_flags & NTF_PROXY) {
> > +             struct pneigh_entry *pn;
> > +
> > +             pn = pneigh_lookup(tbl, net, dst, dev, 0);
> > +             if (!pn) {
> > +                     NL_SET_ERR_MSG(extack, "Proxy neighbour entry not found");
> > +                     return -ENOENT;
> > +             }
> > +             return pneigh_get_reply(net, pn, NETLINK_CB(in_skb).portid,
> > +                                     nlh->nlmsg_seq, tbl);
> > +     }
> > +
> > +     if (!dev) {
> > +             NL_SET_ERR_MSG(extack, "No Device specified");
>
> "No device ..."
>

ack