netdev - Re: [Patch net] ipv6: explicitly initialize udp6_addr in udp_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 12:10:19 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, jon.maloy@...csson.com
Subject: Re: [Patch net] ipv6: explicitly initialize udp6_addr in
 udp_sock_create6()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue, 18 Dec 2018 21:17:44 -0800

> syzbot reported the use of uninitialized udp6_addr::sin6_scope_id.
> We can just set ::sin6_scope_id to zero, as tunnels are unlikely
> to use an IPv6 address that needs a scope id and there is no
> interface to bind in this context.
> 
> For net-next, it looks different as we have cfg->bind_ifindex there
> so we can probably call ipv6_iface_scope_id().
> 
> Same for ::sin6_flowinfo, tunnels don't use it.
> 
> Fixes: 8024e02879dd ("udp: Add udp_sock_create for UDP tunnels to open listener socket")
> Reported-by: syzbot+c56449ed3652e6720f30@...kaller.appspotmail.com
> Cc: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks Cong.