netdev - Re: [PATCH] tools: bpftool: do not force gcc as CC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f53f3c5b-ad74-63f8-0edd-ea2c3cf64bec@iogearbox.net>
Date:   Wed, 19 Dec 2018 22:04:21 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Ivan Babrou <ivan@...udflare.com>, netdev@...r.kernel.org
Cc:     sdf@...ichev.me, trivial@...nel.org, jolsa@...nel.org,
        jakub.kicinski@...ronome.com, ast@...nel.org
Subject: Re: [PATCH] tools: bpftool: do not force gcc as CC

On 12/19/2018 09:08 PM, Ivan Babrou wrote:
> This allows transparent cross-compilation with CROSS_COMPILE.
> 
> Signed-off-by: Ivan Babrou <ivan@...udflare.com>

Looks good, applied! So we basically piggy back on 7ed1c1901fe5 ("tools:
fix cross-compile var clobbering") which moved everything to the
tools/scripts/Makefile.include which bpftool includes. Could we
then also reduce tools/lib/bpf/Makefile as well for cross-compilation?
Looks like this has bunch of duplicate logic and yet we pull in the
Makefile.include as well there.

Thanks,
Daniel