netdev - Re: [PATCH bpf-next 0/2] Ensure line_info.insn_off cannot point to insn with zero code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3e9b297-2afe-257d-bb80-833f2d5dd69c@fb.com>
Date:   Wed, 19 Dec 2018 21:27:24 +0000
From:   Yonghong Song <yhs@...com>
To:     Martin Lau <kafai@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 0/2] Ensure line_info.insn_off cannot point to
 insn with zero code



On 12/19/18 1:01 PM, Martin KaFai Lau wrote:
> This series ensures the line_info (passed by the userspace during
> bpf_prog_load) cannot have its line_info.insn_off pointing to a
> zero bpf insn code.  F.e. a broken userspace tool might
> generate a line_info.insn_off that points to the second
> 8 bytes of a BPF_LD_IMM64.
> 
> The first patch is the kernel change.
> The second patch is a new test case.
> 
> Martin KaFai Lau (2):
>    bpf: Ensure line_info.insn_off cannot point to insn with zero code
>    bpf: Add BPF_LD_IMM64 to the line_info test
> 
>   kernel/bpf/verifier.c                  |  8 ++++++++
>   tools/testing/selftests/bpf/test_btf.c | 27 ++++++++++++++++++++++++++
>   2 files changed, 35 insertions(+)

Looks good to me. For the whole series,
Acked-by: Yonghong Song <yhs@...com>