netdev - RE: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 23:19:47 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <Tristram.Ha@...rochip.com>
CC:     <vivien.didelot@...oirfairelinux.com>,
        <UNGLinuxDriver@...rochip.com>, <netdev@...r.kernel.org>,
        <sergio.paracuellos@...il.com>, <andrew@...n.ch>,
        <f.fainelli@...il.com>, <pavel@....cz>, <marex@...x.de>,
        <dan.carpenter@...cle.com>
Subject: RE: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

> > Is there any specific reason that ksz_i2c_read24 & ksz_i2c_write24 in
> > ksz9477_i2c.c
> > but, other functions are in ksz_i2c.h?
> >
> 
> There are specific registers in KSZ9477 such that using 24-bit is more efficient than
> reading 32-bit first and writing 32-bit.  The other older switches mostly use 8-bit, while
> one uses 16-bit.
> 
Meant location of functions than usage of function.

Because comments about using single C file, this can be ignored if do so.

Thanks.
Woojung