netdev - Re: [PATCH net] tcp: clear tp->retrans_stamp in tcp_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181219.154700.375507482021008830.davem@davemloft.net>
Date:   Wed, 19 Dec 2018 15:47:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org, soheil@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] tcp: clear tp->retrans_stamp in
 tcp_finish_connect()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 19 Dec 2018 15:27:19 -0800

> On 12/19/2018 01:50 PM, Eric Dumazet wrote:
>> tcp_connect() does :
>> 
>>      tp->retrans_stamp = tcp_time_stamp(tp);
>> 
>> When 3WHS completes, we need to clear retrans_stamp otherwise
>> various things can break.
>> 
>> This bug became more visible after commit b701a99e431d ("tcp: Add
>> tcp_clamp_rto_to_user_timeout() helper to improve accuracy"), but
>> predates git history.
>> 
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> 
> David please disregard this patch. tp->retrans_stamp is already cleared
> in tcp_clean_rtx_queue() when the SYN packet is removed from rtx queue.

Ok.