netdev - Re: [PATCH net] net: phy: Fix the issue that netif always links up after resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Dec 2018 21:49:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hayashi.kunihiko@...ionext.com
Cc:     hkallweit1@...il.com, andrew@...n.ch, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: Fix the issue that netif always links up
 after resuming

From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Date: Tue, 18 Dec 2018 16:57:04 +0900

> Even though the link is down before entering hibernation,
> there is an issue that the network interface always links up after resuming
> from hibernation.
> 
> If the link is still down before enabling the network interface,
> and after resuming from hibernation, the phydev->state is forcibly set
> to PHY_UP in mdio_bus_phy_restore(), and the link becomes up.
> 
> In suspend sequence, only if the PHY is attached, mdio_bus_phy_suspend()
> calls phy_stop_machine(), and mdio_bus_phy_resume() calls
> phy_start_machine().
> In resume sequence, it's enough to do the same as mdio_bus_phy_resume()
> because the state has been preserved.
> 
> This patch fixes the issue by calling phy_start_machine() in
> mdio_bus_phy_restore() in the same way as mdio_bus_phy_resume().
> 
> Suggested-by: Heiner Kallweit <hkallweit1@...il.com>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

Applied and queued up for -stable.