netdev - Re: [PATCH] xen/netfront: tolerate frags with no data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <425ca7b2-de7b-0490-0f10-e64dce1a6e28@suse.com>
Date:   Wed, 19 Dec 2018 07:02:52 +0100
From:   Juergen Gross <jgross@...e.com>
To:     David Miller <davem@...emloft.net>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        xen-devel@...ts.xenproject.org, sstabellini@...nel.org,
        boris.ostrovsky@...cle.com, stable@...r.kernel.org
Subject: Re: [PATCH] xen/netfront: tolerate frags with no data

On 19/12/2018 07:00, David Miller wrote:
> From: Juergen Gross <jgross@...e.com>
> Date: Tue, 18 Dec 2018 16:06:19 +0100
> 
>> At least old Xen net backends seem to send frags with no real data
>> sometimes. In case such a fragment happens to occur with the frag limit
>> already reached the frontend will BUG currently even if this situation
>> is easily recoverable.
>>
>> Modify the BUG_ON() condition accordingly.
>>
>> Tested-by: Dietmar Hahn <dietmar.hahn@...fujitsu.com>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
> 
> Applied and queued up for -stable.
> 
> But many of these BUG's in the driver should be converted to
> WARNs and recovery code added.
> 

Right, but that will be no stable material then. Will start that effort
after Christmas.


Juergen