netdev - Re: [PATCH] vxge: ensure data0 is initialized in when fetching firmware version information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181218.220344.197132278908226283.davem@davemloft.net>
Date:   Tue, 18 Dec 2018 22:03:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     jdmason@...zu.us, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vxge: ensure data0 is initialized in when fetching
 firmware version information

From: Colin King <colin.king@...onical.com>
Date: Tue, 18 Dec 2018 15:19:47 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently variable data0 is not being initialized so a garbage value is
> being passed to vxge_hw_vpath_fw_api and this value is being written to
> the rts_access_steer_data0 register.  There are other occurrances where
> data0 is being initialized to zero (e.g. in function
> vxge_hw_upgrade_read_version) so I think it makes sense to ensure data0
> is initialized likewise to 0.
> 
> Detected by CoverityScan, CID#140696 ("Uninitialized scalar variable")
> 
> Fixes: 8424e00dfd52 ("vxge: serialize access to steering control register")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.