netdev - Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1545328145.185366.500.camel@acm.org>
Date:   Thu, 20 Dec 2018 09:49:05 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Joe Perches <joe@...ches.com>
Cc:     Stephen Warren <swarren@...dotorg.org>,
        Tariq Toukan <tariqt@...lanox.com>, xavier.huwei@...wei.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        Doug Ledford <dledford@...hat.com>,
        Stephen Warren <swarren@...dia.com>,
        Christoph Hellwig <hch@....de>, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH V3] net/mlx4: Get rid of page operation after
 dma_alloc_coherent

On Thu, 2018-12-20 at 18:44 +0100, Christoph Hellwig wrote:
> On Thu, Dec 20, 2018 at 10:43:18AM -0700, Jason Gunthorpe wrote:
> > >   - chunk->coherent is an int not a bool since checkpatch complains about
> > >     using bool in structs; see https://lkml.org/lkml/2017/11/21/384.
> > 
> > :( bool is much more readable and there is no performance concern in
> > this struct. I think checkpatch is overzealous here.
> 
> Yes.  Nevermind that this for bool vs bitfield.  A int is worse in
> every respect in the criteria used in that mail.

(+Joe Perches)

Hi Joe,

This is the second time that I see that the checkpatch complaint about using
bool in a structure leads kernel contributors to a bad decision. Please consider
removing that warning from checkpatch.

Thanks,

Bart.