netdev - Re: [PATCH v2] ppp: Move PFC decompression to PPP generic layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181220214103.gq67pakntf4bqkrr@kdev>
Date:   Thu, 20 Dec 2018 22:42:15 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ppp: Move PFC decompression to PPP generic layer

On Thu, Dec 20, 2018 at 08:29:20PM +0200, Sam Protsenko wrote:
> Extract "Protocol" field decompression code from transport protocols to
> PPP generic layer, where it actually belongs. As a consequence, this
> patch fixes incorrect place of PFC decompression in L2TP driver (when
> it's not PPPOX_BOUND) and also enables this decompression for other
> protocols, like PPPoE.
> 
Nice to see PFC implementation moving to ppp_generic.

> Protocol field decompression also happens in PPP Multilink Protocol
> code and in PPP compression protocols implementations (bsd, deflate,
> mppe). It looks like there is no easy way to get rid of that, so it was
> decided to leave it as is, but provide those cases with appropriate
> comments instead.
> 
Thanks a lot for taking care of all these particular cases.

Reviewed-by: Guillaume Nault <g.nault@...halink.fr>

Just a side note, this is for net-next. It's better to make that
explicit by using a subject prefix like [PATCH net-next].

> Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> ---
> Changes in v2:
>   - Fix the order of checking skb data room and proto decompression
>   - Remove "inline" keyword from ppp_decompress_proto()
>   - Don't split line before function name
>   - Prefix ppp_decompress_proto() function with "__"
>   - Add ppp_decompress_proto() function with skb data room checks
>   - Add description for introduced functions
>   - Fix comments (as per review on mailing list)
> 
Also, for networking patches, list of changes normally goes into the
commit message.