netdev - Re: [PATCH net-next] net: sched: add checks for tbf classid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Dec 2018 10:18:49 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: sched: add checks for tbf classid

On Thu, Dec 20, 2018 at 1:40 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Tue, Dec 18, 2018 at 11:08 PM <xiangxia.m.yue@...il.com> wrote:
> >
> > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> >
> > tbf has only one qdisc class. When adding qdisc for it,
> > we should check the classid, otherwise the parentid:1
> > classid is available, no matter what classid tc specified.
> >
> > $ tc qdisc add dev eth1 handle 10: root tbf rate 0.5mbit burst 5kb latency 70ms
> > $ tc class show dev eth1
> > class tbf 10:1 parent 10:
> >
> > $ tc qdisc add dev eth1 parent 10:2 handle 20: pfifo_fast
> > or
> > $ tc qdisc add dev eth1 parent 10:0 handle 20: pfifo_fast
> > $ tc class show dev eth1
> > class tbf 10:1 parent 10: leaf 20:
>
> I think it is the intended behavior of tbf class.
The parent id such as parent-id:0 is invalid for other qdisc, is
available for tbf. It is confused for administrator.
Should we add that check ?