netdev - Re: [PATCH net-next 00/11] mlxsw: Two usability improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181220.154913.1271881519017878774.davem@davemloft.net>
Date:   Thu, 20 Dec 2018 15:49:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next 00/11] mlxsw: Two usability improvements

From: Ido Schimmel <idosch@...lanox.com>
Date: Thu, 20 Dec 2018 19:42:22 +0000

> This patchset contains two small improvements in the mlxsw driver. The
> first one, in patches #1-#2, relieves the user from the need to
> configure a VLAN interface and only later the corresponding VXLAN
> tunnel. The issue is explained in detail in the first patch.
> 
> The second improvement is described below and allows the user to make
> use of VID 1 by having the driver use the reserved 4095 VID for untagged
> traffic.
> 
> VLAN entries on a given port can be associated with either a bridge or a
> router. For example, if swp1.10 is assigned an IP address and swp1.20 is
> enslaved to a VLAN-unaware bridge, then both {Port 1, VID 10} and {Port
> 1, VID 20} would be associated with a filtering identifier (FID) of the
> correct type.
> 
> In case swp1 itself is assigned an IP address or enslaved to a
> VLAN-unaware bridge, then a FID would be associated with {Port 1, VID
> 1}. Using VID 1 for this purpose means that VLAN devices with VID 1
> cannot be created over mlxsw ports, as this VID is (ab)used as the
> default VLAN.
> 
> Instead of using VID 1 for this purpose, we can use VID 4095 which is
> reserved for internal use and cannot be configured by either the 8021q
> or the bridge driver.
> 
> Patches #3-#7 perform small and non-functional changes that finally
> allow us to switch to VID 4095 as the default VID in patch #8.
> 
> Patch #9 removes the limitation about creation of VLAN devices with VID
> 1 over mlxsw ports.
> 
> Patches #10-#11 add test cases.

Series applied, thanks.