netdev - RE: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HE1PR05MB47964508A05F8B74092C01A9A3B80@HE1PR05MB4796.eurprd05.prod.outlook.com>
Date:   Fri, 21 Dec 2018 09:29:36 +0000
From:   Achiad Shochat <achiad@...lanox.com>
To:     Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>
CC:     Doug Ledford <dledford@...hat.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: RE: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as
 some general object

Great, thanks


-----Original Message-----
From: Jason Gunthorpe <jgg@...pe.ca> 
Sent: Thursday, December 20, 2018 11:02 PM
To: Leon Romanovsky <leon@...nel.org>
Cc: Doug Ledford <dledford@...hat.com>; Yishai Hadas <yishaih@...lanox.com>; RDMA mailing list <linux-rdma@...r.kernel.org>; Achiad Shochat <achiad@...lanox.com>; Saeed Mahameed <saeedm@...lanox.com>; linux-netdev <netdev@...r.kernel.org>; Leon Romanovsky <leonro@...lanox.com>
Subject: Re: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

On Wed, Dec 19, 2018 at 04:28:15PM +0200, Leon Romanovsky wrote:
> From: Yishai Hadas <yishaih@...lanox.com>
> 
> The driver needs to prevent a user space application to create a UMEM 
> and UCTX via the general object command.
> 
> The UMEM must go through the kernel UMEM_REG method to prevent the 
> user from setting physical addresses by himself.  The UCTX is some 
> internal kernel object and shouldn't be exposed.
> 
> As of not being any more part of the general object the caps bits were 
> moved to be some log_xxx indication in the general HCA caps, 0 means 
> not supported.
> 
> The firmware code was adapted as well to match the above.
> 
> Signed-off-by: Yishai Hadas <yishaih@...lanox.com>
> Reviewed-by: Achiad Shochat <achiad@...lanox.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> ---
>  drivers/infiniband/hw/mlx5/devx.c | 34 ++++++++---------  
> drivers/infiniband/hw/mlx5/main.c |  3 +-
>  include/linux/mlx5/mlx5_ifc.h     | 62 +++++++++++++++++++++----------
>  3 files changed, 58 insertions(+), 41 deletions(-)

Applied to for-next

Thanks,
Jason