netdev - Re: [PATCH iproute2 1/1] testsuite: Fix colorize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181221130402.GA15447@dell5510>
Date:   Fri, 21 Dec 2018 14:04:03 +0100
From:   Petr Vorel <pvorel@...e.cz>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/1] testsuite: Fix colorize

Hi Stephen,

> On Tue, 18 Dec 2018 20:29:04 +0100
> Petr Vorel <pvorel@...e.cz> wrote:

> > bash and dash require for escape sequence to use 'echo -e' or printf
> > (but working on zsh). Choosing printf as it's implementation is IMHO
> > more portable than echo implementations.
> > dash also require to use \033[0; as escape sequence instead of \e[0;

> > NOTE: \e[0; kept in lib/color.c as it's not problematic for C code
> > (working when run ip on various shells).

> > Fixes: 7e2f71b4 ("testsuite: colorize test result output")

> > Signed-off-by: Petr Vorel <pvorel@...e.cz>

> Sure applied. Not sure why people expect tests to work without
> bash. Next they will want it to work with clang on BSD...

Understand your frustration about useless fixes, but actually the reason for me
to fail this patch was that it does not work on bash on Tumbleweed:

Now testing on Debian and it's working.

Not sure what causes that as echo "\e[0;32mPASS\e[0m" run in bash is broken on
both (both distros have bash version 4.4.23(1)-release):
$ echo "\e[0;32mPASS\e[0m"
\e[0;32mPASS\e[0m

Kind regards,
Petr