netdev - Re: [PATCH] net: netxen: fix a missing check and an uninitialized use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181221.090201.51665179504686411.davem@davemloft.net>
Date:   Fri, 21 Dec 2018 09:02:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kjlu@....edu
Cc:     pakki001@....edu, manish.chopra@...ium.com, rahul.verma@...ium.com,
        Dept-GELinuxNICDev@...ium.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: netxen: fix a missing check and an uninitialized
 use

From: Kangjie Lu <kjlu@....edu>
Date: Fri, 21 Dec 2018 00:22:32 -0600

> When netxen_rom_fast_read() fails, "bios" is left uninitialized and may
> contain random value, thus should not be used.
> 
> The fix ensures that if netxen_rom_fast_read() fails, we return "-EIO".
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

Applied, thanks.