netdev - Re: [PATCH net-next] tls: Do not call sk_memcopy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Dec 2018 10:27:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com, doronrk@...com
Subject: Re: [PATCH net-next] tls: Do not call sk_memcopy_from_iter with
 zero length

From: Vakul Garg <vakul.garg@....com>
Date: Fri, 21 Dec 2018 17:41:47 +0000

> The variable 'ret' is already set to the return value of
> tls_clone_plaintext_msg().  In case try_to_copy != 0, the value of
> 'ret' is overwritten with return value of
> sk_msg_memcopy_from_iter().  In case try_to_copy == 0, the value of
> 'ret' remains same as the one set to return value of
> tls_clone_plaintext_msg().  Subsequently, 'if (full_record || eor)'
> does not fufill, we continue and do not read 'ret'.  If 'if
> (full_record || eor)' evaluates true, value of ret is overwritten by
> return value of bpf_exec_tx_verdict().  So I do not find the
> problem.
> 
> Kindly advise if I am missing your point.

Indeed you are right.

Applied to 'net' with the Fixes: tag location adjusted.

Thanks.