netdev - Re: [PATCH v2 bpf-next 3/4] bpf: Make more use of 'any' alignment in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34bd197f-593d-55b0-0d07-753c38e21314@gmail.com>
Date:   Fri, 21 Dec 2018 10:57:30 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, daniel@...earbox.net
Cc:     ast@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 bpf-next 3/4] bpf: Make more use of 'any' alignment in
 test_verifier.c



On 11/30/2018 09:08 PM, David Miller wrote:
> 
> Use F_NEEDS_EFFICIENT_UNALIGNED_ACCESS in more tests where the
> expected result is REJECT.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  tools/testing/selftests/bpf/test_verifier.c | 44 +++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
> index 428a84d..5d97fb8 100644
> --- a/tools/testing/selftests/bpf/test_verifier.c
> +++ b/tools/testing/selftests/bpf/test_verifier.c
> @@ -1823,6 +1823,7 @@ static struct bpf_test tests[] = {
>  		.errstr = "invalid bpf_context access",
>  		.result = REJECT,
>  		.prog_type = BPF_PROG_TYPE_SK_MSG,
> +		.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
>  	},
>  	{
>  		"direct packet read for SK_MSG",
> @@ -2187,6 +2188,8 @@ static struct bpf_test tests[] = {
>  		},
>  		.errstr = "invalid bpf_context access",
>  		.result = REJECT,
> +		.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
> +		.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,


Note that clang does not like .flags being duplicated here.

Thanks.