netdev - Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a960bfa-000a-eb14-814b-476da5c1f5df@gmail.com>
Date:   Sat, 22 Dec 2018 10:30:58 +1300
From:   Michael Schmitz <schmitzmic@...il.com>
To:     David Miller <davem@...emloft.net>, alex@...ik.de
Cc:     netdev@...r.kernel.org, linux-m68k@...r.kernel.org,
        rolf.anders@...sik.uni-augsburg.de
Subject: Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

Dave,

Am 21.12.2018 um 13:10 schrieb David Miller:
> From: ALeX Kazik <alex@...ik.de>
> Date: Wed, 19 Dec 2018 23:24:32 +0100
>
>> +	bool "PCMCIA NE2000 100MBit support"
>> +	default n
>> +	depends on ARM_ETHERH=n && AX88796=n && HYDRA=n && MAC8390=n
>> +	depends on MCF8390=n && NE2000=n && NE2K_PCI=n && PCMCIA_AXNET=n
>> +	depends on PCMCIA_PCNET=n && STNIC=n && ULTRA=n && WD80x3=n
>> +	depends on XSURF100=n && ZORRO8390=n
>> +	---help---
>
> Generally I'm not too happy with these changes, they are all very hackish.

I see only one option to address that: rewrite apne.c to include 
lib8390.c directly.

Moving the inb() and outb() redefines into the m68k version of io.h 
(which Geert is likely to veto because of its hackishness) would still 
require a Kconfig hack.

> And in particular this huge complicated Kconfig construct is not
> maintainable at all.

We can trim this down a bit (for reasons I've outlined before):

+if APNE
+config APNE100MBIT
+	bool "PCMCIA NE2000 100MBit support"
+	default n
+	depends on NE2000=n && PCMCIA_AXNET=n
+	depends on PCMCIA_PCNET=n && STNIC=n && ULTRA=n && WD80x3=n

In all honesty, I doubt anyone could ever use the stnic, ultra and wd 
drivers on m68k (Geert?) so these could be omitted as well. Not sure 
pcnet_cs or axnet_cs are possible to use on the Amiga PCMCIA slot, so 
all that remains in practice is the ne driver (which is used on Atari).

Still too ugly?

Cheers,

	Michael

>
> Sorry.
>