netdev - Re: [PATCH] ipv6: frags: Fix bogus skb->sk in reassembled packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181220.163221.1065508650564806525.davem@davemloft.net>
Date:   Thu, 20 Dec 2018 16:32:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     steffen.klassert@...unet.com, netdev@...r.kernel.org,
        xmu@...hat.com, edumazet@...gle.com
Subject: Re: [PATCH] ipv6: frags: Fix bogus skb->sk in reassembled packets

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 20 Dec 2018 21:20:10 +0800

> It was reported that IPsec would crash when it encounters an IPv6
> reassembled packet because skb->sk is non-zero and not a valid
> pointer.
> 
> This is because skb->sk is now a union with ip_defrag_offset.
> 
> This patch fixes this by resetting skb->sk when exiting from
> the reassembly code.
> 
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Fixes: 219badfaade9 ("ipv6: frags: get rid of ip6frag_skb_cb/...")
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied and queued up for -stable, thanks Herbert.