netdev - Re: [PATCH net 0/2] net: ipv4: Prevent user triggerable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181220.172713.1077611251269815184.davem@davemloft.net>
Date:   Thu, 20 Dec 2018 17:27:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, dsahern@...il.com,
        alexpe@...lanox.com
Subject: Re: [PATCH net 0/2] net: ipv4: Prevent user triggerable warning

From: Ido Schimmel <idosch@...lanox.com>
Date: Thu, 20 Dec 2018 17:03:26 +0000

> Patch #1 prevents a user triaggerable warning in the flow dissector by
> setting 'skb->dev' in skbs used for IPv4 output route get requests.
> 
> Patch #2 adds a test case that triggers the warning without the first
> patch.
> 
> I have audited all the RTM_GETROUTE handlers and could not find any
> other callpath where an skb is passed to the flow dissector with both
> 'skb->dev' and 'skb->sk' cleared.

I'll apply this, thanks Ido.