netdev - RE: [RFT][PATCH 6/7] net: dsa: microchip: Initial SPI regmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY1PR11MB043975FD2FD778396A9FB586ECB80@BY1PR11MB0439.namprd11.prod.outlook.com>
Date:   Fri, 21 Dec 2018 01:30:30 +0000
From:   <Tristram.Ha@...rochip.com>
To:     <marex@...x.de>
CC:     <f.fainelli@...il.com>, <andrew@...n.ch>,
        <Woojung.Huh@...rochip.com>, <netdev@...r.kernel.org>
Subject: RE: [RFT][PATCH 6/7] net: dsa: microchip: Initial SPI regmap support

> +static const struct regmap_config ksz9477_regmap_config = {
> +	.reg_bits = 32,
> +	.val_bits = 8,
> +	.max_register = 0x100,
> +	.cache_type = REGCACHE_RBTREE,
> +	.read_flag_mask = KS_SPIOP_RD << SPI_ADDR_SHIFT,
> +	.write_flag_mask = KS_SPIOP_WR << SPI_ADDR_SHIFT,
> +	.reg_format_endian = REGMAP_ENDIAN_BIG,
> +	.val_format_endian = REGMAP_ENDIAN_BIG,
> +};

As you have KSZ8795 can you verify regmap works?

I think you need to add reg_shift.