netdev - Re: [PATCH net] tcp: fix a race in inet_diag_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181220.192420.1749187543769739613.davem@davemloft.net>
Date:   Thu, 20 Dec 2018 19:24:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, ast@...nel.org,
        jonathan.lemon@...il.com
Subject: Re: [PATCH net] tcp: fix a race in inet_diag_dump_icsk()

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 20 Dec 2018 15:28:56 -0800

> Alexei reported use after frees in inet_diag_dump_icsk() [1]
> 
> Because we use refcount_set() when various sockets are setup and
> inserted into ehash, we also need to make sure inet_diag_dump_icsk()
> wont race with the refcount_set() operations.
> 
> Jonathan Lemon sent a patch changing net_twsk_hashdance() but
> other spots would need risky changes.
> 
> Instead, fix inet_diag_dump_icsk() as this bug came with
> linux-4.10 only.
> 
> [1] Quoting Alexei :
 ...
> Fixes: 67db3e4bfbc9 ("tcp: no longer hold ehash lock while calling tcp_get_info()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Alexei Starovoitov <ast@...nel.org>
> Cc: Jonathan Lemon <jonathan.lemon@...il.com>

Applied and queued up for -stable, thanks Eric.