netdev - Re: [PATCH 3/8] net: dsa: adding handling of second CPU-Port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F7949D96-8D9B-42A4-AE82-F77B3C4CEAC2@public-files.de>
Date:   Sun, 23 Dec 2018 11:02:39 +0100
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     linux-mediatek@...ts.infradead.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        netdev@...r.kernel.org, Sean Wang <sean.wang@...iatek.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH 3/8] net: dsa: adding handling of second CPU-Port

Hi,
I got mail from kernelci regarding a null-pointer exception in dsa_slave_create.

I'm sure thats from uninitialized ethernet-option (maybe by missing dts-option).

struct net_device *master = ds->ports[port->upstream].ethernet;

Which is defined in new function dsa_user_parse. maybe a good place for fallback using 

dsa_port *cpu_dp = port->cpu_dp;
net_device *master = cpu_dp->master;

Should i implement a fallback? I'm asking because dsa-maintainers want to drop dts-option and want to realize it via manual bridging user-port to cpu-port instead of defining this connection in devicetree.

Regards Frank

Mit freundlichen Grüßen
Frank Wunderlich