netdev - Re: [PATCH net] packet: validate address length if non-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+0RiqGaLpFbgC4j6cEeU=ZgmfOnLpQ0m+Owx5Peh5dmw@mail.gmail.com>
Date:   Sun, 23 Dec 2018 11:30:38 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Network Development <netdev@...r.kernel.org>,
        Ido Schimmel <idosch@...sch.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] packet: validate address length if non-zero

On Sat, Dec 22, 2018 at 6:13 PM David Miller <davem@...emloft.net> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Date: Sat, 22 Dec 2018 16:53:45 -0500
>
> > From: Willem de Bruijn <willemb@...gle.com>
> >
> > Validate packet socket address length if a length is given. Zero
> > length is equivalent to not setting an address.
> >
> > Fixes: 99137b7888f4 ("packet: validate address length")
> > Reported-by: Ido Schimmel <idosch@...sch.org>
> > Signed-off-by: Willem de Bruijn <willemb@...gle.com>
>
> Applied, thanks Willem.
>
> I'll put this into -stable next to the patch it fixes.

Thanks David. Sorry for the earlier cock-up.

Looking at this, I noticed one header_ops.create implementation that
always expects non-zero daddr. Will send a small fix for that, too.