netdev - Re: [PATCH net] net: phy: fix phy_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9fbe47e-60de-c9d4-604b-3ecfb74a8768@gmail.com>
Date:   Sun, 23 Dec 2018 18:30:47 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

On 23.12.2018 18:28, Andrew Lunn wrote:
> On Sun, Dec 23, 2018 at 06:23:18PM +0100, Heiner Kallweit wrote:
>> On 23.12.2018 18:07, Andrew Lunn wrote:
>>> On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote:
>>>> Currently we return immediately if callback config_init isn't defined.
>>>> This prevents the fixups from being executed. I see no dependency
>>>> between fixups and config_init, therefore change the function to
>>>> run the fixups also if config_init isn't defined.
>>>>
>>>> Fixes: 2f5cb43406d0 ("phylib: Properly reinitialize PHYs after hibernation")
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>>>
>>> Hi Heiner
>>>
>>> Is this a real fix? It seems like it has been like this forever. Do
>>> you know of a PHY which is actually broken?
>>>
>> Right, the current behavior has been there forever. I'm not aware of
>> any concrete case. I went for "net" because the current code could
>> break a device.
> 
> Hi Heiner
> 
> https://www.kernel.org/doc/html/v4.15/process/stable-kernel-rules.html
> 
> The 4th bullet point:
> 
> o It must fix a real bug that bothers people (not a, “This could be a
>   problem...” type thing).
> 
OK, this answers the question. Thanks.

>     Andrew
> 
Heiner