netdev - Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181224.095846.1987517984305782151.davem@davemloft.net>
Date:   Mon, 24 Dec 2018 09:58:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, linux@...ck-us.net,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH net-next] staging: octeon: fix build failure with XFRM
 enabled

From: Florian Westphal <fw@...len.de>
Date: Fri, 21 Dec 2018 21:57:26 +0100

> skb->sp doesn't exist anymore in the next-next tree, so mips defconfig
> no longer builds.  Use helper instead to reset the secpath.
> 
> Not even compile tested.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Fixes: 4165079ba328d ("net: switch secpath to use skb extension infrastructure")
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  Greg, David:
> 
>  The patch will not break build for a tree that lacks the 'Fixes'
>  commit, so this can also go in via staging tree.
>  OTOH, net-next build is broken for mips/octeon, so I think in
>  this case net-next might make more sense?

Yeah I agree, that net-next is probably the best place for this.

Because I know that Linus is sensitive to situations where he is
sent a pull request, and then what he pulls doesn't match the pull
request shortlog etc.  I have asked him how he would let me handle
this.

That's the only reason I haven't integrated this yet.

Just FYI!