netdev - Re: [PATCH net] net: dccp: fix kernel crash on module load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181224.152815.928771539327201922.davem@davemloft.net>
Date:   Mon, 24 Dec 2018 15:28:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     posk@...gle.com
Cc:     netdev@...r.kernel.org, posk.devel@...il.com, lkp@...el.com
Subject: Re: [PATCH net] net: dccp: fix kernel crash on module load

From: Peter Oskolkov <posk@...gle.com>
Date: Mon, 24 Dec 2018 12:57:17 -0800

> Patch eedbbb0d98b2 "net: dccp: initialize (addr,port) ..."
> added calling to inet_hashinfo2_init() from dccp_init().
> 
> However, inet_hashinfo2_init() is marked as __init(), and
> thus the kernel panics when dccp is loaded as module. Removing
> __init() tag from inet_hashinfo2_init() is not feasible because
> it calls into __init functions in mm.
> 
> This patch adds inet_hashinfo2_init_mod() function that can
> be called after the init phase is done; changes dccp_init() to
> call the new function; un-marks inet_hashinfo2_init() as
> exported.
> 
> Fixes: eedbbb0d98b2 ("net: dccp: initialize (addr,port) ...")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>

Applied, thanks.