netdev - Re: [PATCH net] net: phy: fix phy_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Dec 2018 07:59:33 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phy: fix phy_init_hw fixup handling

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 25 Dec 2018 09:30:45 +0100

> On 24.12.2018 23:23, David Miller wrote:
>> From: Heiner Kallweit <hkallweit1@...il.com>
>> Date: Sun, 23 Dec 2018 15:00:26 +0100
>> 
>>> Currently we return immediately if callback config_init isn't defined.
>>> This prevents the fixups from being executed. I see no dependency
>>> between fixups and config_init, therefore change the function to
>>> run the fixups also if config_init isn't defined.
>>>
>>> Fixes: 2f5cb43406d0 ("phylib: Properly reinitialize PHYs after hibernation")
>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> 
>> As per the discussion, let's defer this to when net-next opens back up.
>> 
> For my understanding, are you going to pick up deferred patches like this
> when net-next opens or should I resubmit?

You always need to resubmit, it is the only sane way for me to keep track
of things.

Thanks for asking.