lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Dec 2018 11:06:08 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Colin King <colin.king@...onical.com>, "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][V2] drivers/net: appletalk/cops: remove redundant if statement and mask On 24.12.2018 22:41, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > The two different assignments for pkt_len are actually the same and > so the if statement is redundant and can be removed. Masking a u8 > return value from inb() with 0xFF is also redundant and can also be > emoved. Removed. :-) > Similarly, the two different outb calls are identical as the mask > of 0xff on the second outb is redundant since a u8 is being written, > so the if statement is also redundant and can be also removed. > > Detected by CoverityScan, CID#1475639 ("Identical code for different > branches") > > --- > > V2: Remove the if statement for the outb calls, thanks to David > Miller for spotting this. > > Signed-off-by: Colin Ian King <colin.king@...onical.com> [...] MBR, Sergei
Powered by blists - more mailing lists